Re: TAP tests aren't using the magic words for Windows file access - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: TAP tests aren't using the magic words for Windows file access
Date
Msg-id CAC+AXB1V5uXLfgqjY-xUpJ_4QYtiy0Z5azZdhienbR4qOHd6iQ@mail.gmail.com
Whole thread Raw
In response to Re: TAP tests aren't using the magic words for Windows file access  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: TAP tests aren't using the magic words for Windows file access  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On Wed, Nov 6, 2019 at 4:38 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
On 2019-Nov-05, Michael Paquier wrote:

> On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote:
> > That is, TestLib::slurp_file is failing to read a file.  Almost
> > certainly, "permission denied" doesn't really mean a permissions
> > problem, but failure to specify the file-opening flags needed to
> > allow concurrent access on Windows.  We fixed this in pg_ctl
> > itself in commit 0ba06e0bf ... but we didn't fix the TAP
> > infrastructure.  Is there an easy way to get Perl on board
> > with that?
>
> If we were to use Win32API::File so as the file is opened in shared
> mode, we would do the same as what our frontend/backend code does (see
> $uShare):
> https://metacpan.org/pod/Win32API::File

Compatibility-wise, that should be okay, since that module appears to
have been distributed with Perl core early on.


Please find attached a patch that adds the FILE_SHARE options to TestLib::slurp_file using Win32API::File.

Regards,

Juan José Santamaría Flecha
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Using multiple extended statistics for estimates
Next
From: Andrzej Barszcz
Date:
Subject: question