Re: factorial of negative numbers - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: factorial of negative numbers
Date
Msg-id CAC+AXB1AFZRYXL+qNdyJjYPEwZ01nUMij7wg2soKAcsBqDO3yA@mail.gmail.com
Whole thread Raw
In response to Re: factorial of negative numbers  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: factorial of negative numbers  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers

On Thu, Jun 18, 2020 at 9:13 AM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 2020-06-16 14:17, Dean Rasheed wrote:
> I think you're probably right though. Raising an out-of-range error
> seems like the best option.

committed as proposed then

The gamma function from math.h returns a NaN for negative integer values, the postgres factorial function returns a numeric, which allows NaN. Raising an out-of-range error seems only reasonable for an integer output.

Regards,

Juan José Santamaría Flecha

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Review for GetWALAvailability()
Next
From: Michael Paquier
Date:
Subject: Re: Physical replication slot advance is not persistent