Re: pg_stat_statements: calls under-estimation propagation - Mailing list pgsql-hackers

From Sameer Thakur
Subject Re: pg_stat_statements: calls under-estimation propagation
Date
Msg-id CABzZFEuwfTaD4UUHezkRbF1=yuB9NhJtkCQtw0DVPTNZry2sJg@mail.gmail.com
Whole thread Raw
In response to Re: pg_stat_statements: calls under-estimation propagation  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
>> Please find the patch attached <br />> <br />> Thanks for the patch! Here are the review comments: <br
/>><br />> +    OUT session_start timestamptz, <br />> +    OUT introduced timestamptz, <br />> <br />>
Thepatch exposes these columns in pg_stat_statements view. <br />> These should be documented. <br /> Yes, will add
todocumentation. <br />> I don't think that session_start should be exposed in every <br />> rows in
pg_stat_statementsbecause it's updated only when <br />> all statistics are reset, i.e., session_start of all
entries<br />> in pg_stat_statements indicate the same. <br />I understand. Will remove session_start from view and
exposeit via a <br />function pg_stat_statements_current_session_start() ? <br />> +    OUT query_id int8, <br
/>>query_id or queryid? I like the latter. Also the document <br />> uses the latter. <br />> <br /> Will
changeto queryid <br /><br />Thank you <br />Sameer <br /><br /><hr align="left" width="300" /> View this message in
context:<a
href="http://postgresql.1045698.n5.nabble.com/pg-stat-statements-calls-under-estimation-propagation-tp5738128p5773448.html">Re:
pg_stat_statements:calls under-estimation propagation</a><br /> Sent from the <a
href="http://postgresql.1045698.n5.nabble.com/PostgreSQL-hackers-f1928748.html">PostgreSQL- hackers mailing list
archive</a>at Nabble.com.<br /> 

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [COMMITTERS] pgsql: Add DISCARD SEQUENCES command.
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCH] pg_upgrade: support for btrfs copy-on-write clones