Re: psql line number reporting from stdin - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: psql line number reporting from stdin
Date
Msg-id CABwTF4X67wZvZp7y80zErE41bVb6aE5o29M=6trK4ZArFTGSqw@mail.gmail.com
Whole thread Raw
In response to Re: psql line number reporting from stdin  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: psql line number reporting from stdin
List pgsql-hackers
On Mon, Nov 28, 2011 at 8:10 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Sat, Nov 26, 2011 at 3:36 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> There is a long-standing oddity in psql that running
>
> psql -f foo.sql
>
> returns error messages with file name and line number, like
>
> psql:foo.sql:1: ERROR:  syntax error at or near "foo"
>
> but running
>
> psql < foo.sql does not.  I suggest we change the latter to print
>
> psql:<stdin>:1: ERROR:  syntax error at or near "foo"
>
> Other examples for the use of the spelling "<stdin>" in this context
> include gcc and slonik.
>
> Error messages printed in interactive mode will not be affected, of
> course.
>
> Patch attached.

Seems like a good idea to me.

Naysayers can always make a case for backwards-compatibility, or not breaking the scripts written with the existing behaviour in mind. Do our docs have anything to say about scripts executed from stdin?

--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: odbc_fdw
Next
From: Robert Haas
Date:
Subject: Re: Patch: add timing of buffer I/O requests