Patch: Don't set LoadedSSL unless secure_initialize succeeds - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Patch: Don't set LoadedSSL unless secure_initialize succeeds
Date
Msg-id CABwTF4VOUXC7bpfCzAmTpbsE71FiNnu=FFRB1CRzL1AviD=qWg@mail.gmail.com
Whole thread Raw
Responses Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds
List pgsql-hackers
The initialization in PostmasterMain() blindly turns on LoadedSSL,
irrespective of the outcome of secure_initialize(). I don't think
that's how it should behave, primarily because of the pattern followed
by the other places that call secure_initialize().

This patch makes PostmasterMain() behave identical to other places
(SIGHUP handler, and SubPostmasterMain()) where LoadedSSL is turned on
after checking success of secure_initialize() call. Upon failure of
secure_initialize(), it now emits a log message, instead of setting
LoadedSSL to true.

Best regards,
Gurjeet
http://Gurje.et

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
Next
From: Daniel Gustafsson
Date:
Subject: Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds