Postgres Pro
Downloads
Home   >   mailing lists

Re: Schema version management - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Schema version management
Date
Msg-id CABwTF4UyLBfvQioX32NBzU320+M2maXL5rhsctWTSCPaL6q7xQ@mail.gmail.com
Whole thread Raw
In response to Re: Schema version management  (Joel Jacobson <joel@trustly.com>)
Responses Re: Schema version management
List pgsql-hackers
Tree view
On Thu, Jul 5, 2012 at 3:15 AM, Joel Jacobson <joel@trustly.com> wrote:
On Thu, Jul 5, 2012 at 2:38 AM, Robert Haas <robertmhaas@gmail.com> wrote:
My vote is - when there's an overloaded function, put each version in
its own file.  And name the files something like
functionname_something.sql.  And just document that something may not
be entirely stable.

I would agree that's better if the dump order isn't deterministic.

However, it looks like an easy fix to make the dump order deterministic:

If the dump order is deterministic, I think its cleaner to put all versions in the same file.

Benefits:
+ Pretty looking filename
+ Same file structure for all object types, no special exception for functions

I think there's a merit to keeping all overloaded variations of a function in a single file, apart from the simplicity and benefits noted above. A change in one variation of the function may also be applicable to other variations, say in bug-fixes or enhancements. So keeping all variations in one file would make sense, since it is logically one object.

Best regards,
--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Joel Jacobson
Date:
Subject: Re: Schema version management
Next
From: Shigeru HANADA
Date:
Subject: Re: pgsql_fdw in contrib