Postgres Pro
Downloads
Home   >   mailing lists

Re: Standardize type of variable when extending Buffers - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Standardize type of variable when extending Buffers
Date
Msg-id CABwTF4UgWCp9cxr_WOU1sGSUSdzt+Ar3z-CsPfgv9nG2kEL7uA@mail.gmail.com
Whole thread Raw
In response to Standardize type of variable when extending Buffers  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Standardize type of variable when extending Buffers
List pgsql-hackers
Tree view 
On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Hi,
>
> This has already been discussed in [1].
> But I thought it best to start a new thread.
>
> The commit 31966b1 introduced the infrastructure to extend
> buffers.
> But the patch mixed types with int and uint32.
> The correct type of the variable counter is uint32.
>
> Fix by standardizing the int type to uint32.
>
> patch attached.

LGTM.

+CC Kyotaro, as they were involved in the previous discussion.

>
> [1] https://www.postgresql.org/message-id/CAEudQAr_oWHpZk4uumZijYS362gp4KHAah-yUe08CQY4a4SsOQ%40mail.gmail.com


Best regards,
Gurjeet
http://Gurje.et

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: PATCH: Using BRIN indexes for sorted output
Next
From: Nathan Bossart
Date:
Subject: Re: pgsql: Fix search_path to a safe value during maintenance operations.