Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally. - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.
Date
Msg-id CABwTF4UEcF+3h6khWSdr-RpZ72Hg2D-gZZJRT4+ZjH-kXnHgVQ@mail.gmail.com
Whole thread Raw
In response to Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.  (Kevin Grittner <kgrittn@ymail.com>)
Responses Re: Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Jul 1, 2014 at 10:05 AM, Kevin Grittner <kgrittn@ymail.com> wrote:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
>> If we're going to do it like this, then I think the force flag
>> should be considered to do nothing except override the clock
>> check, which probably means it shouldn't be tested in the initial
>> if() at all.
>
> That makes sense, and is easily done.

Attached is the patch to save you a few key strokes :)

> The only question left is
> how far back to take the patch.  I'm inclined to only apply it to
> master and 9.4.  Does anyone think otherwise?

Considering this as a bug-fix, I'd vote for it to be applied to all
supported releases. But since this may cause unforeseen performance
penalty, I think it should be applied only as far back as the
introduction of PGSTAT_STAT_INTERVAL throttle.

The throttle was implemeted in 641912b, which AFAICT was part of 8.3.
So I guess all the supported releases it is.

Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/

EDB : www.EnterpriseDB.com :  The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Mark Kirkwood
Date:
Subject: Re: Wait free LW_SHARED acquisition
Next
From: Tom Lane
Date:
Subject: Re: SQL access to database attributes