On Fri, Dec 27, 2024 at 9:22 AM vignesh C <vignesh21@gmail.com> wrote:
>
>
> Few comments:
> 1) We have disabled the similar configuration max_slot_wal_keep_size
> by setting to -1, as this GUC also is in similar lines, should we
> disable this and let the user configure it?
> +/*
> + * Invalidate replication slots that have remained idle longer than this
> + * duration; '0' disables it.
> + */
> +int idle_replication_slot_timeout_min =
> HOURS_PER_DAY * MINS_PER_HOUR;
> +
>
I’m okay with setting the default to either '1-day' or 'Off'. Let’s
wait for feedback from others.
>
> 2) I felt this behavior is an existing behavior, so this can also be
> moved to 0001 patch:
> diff --git a/doc/src/sgml/system-views.sgml b/doc/src/sgml/system-views.sgml
> index a586156614..199d7248ee 100644
> --- a/doc/src/sgml/system-views.sgml
> +++ b/doc/src/sgml/system-views.sgml
> @@ -2566,7 +2566,8 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
> </para>
> <para>
> The time when the slot became inactive. <literal>NULL</literal> if the
> - slot is currently being streamed.
> + slot is currently being streamed. If the slot becomes invalidated,
> + this value will remain unchanged until server shutdown.
>
You are correct that the 'inactive_since' value getting reset on
server restart has been the existing behavior.
However, earlier, there was no guarantee that it would remain
unchanged for invalid slots. The new function
"ReplicationSlotSetInactiveSince()" in patch 002, ensures that the
value does not change for invalidated slots until the server is shut
down. Therefore, I feel the doc addition in patch 002 is appropriate.
>
> 3) Can we change the comment below to "We don't allow the value of
> idle_replication_slot_timeout other than 0 during the binary upgrade.
> See start_postmaster() in pg_upgrade for more details.":
> + * The idle_replication_slot_timeout must be disabled (set to 0)
> + * during the binary upgrade.
> + */
> +bool
> +check_idle_replication_slot_timeout(int *newval, void **extra,
> GucSource source)
Done.
--
Thanks,
Nisha
