Re: Improve the connection failure error messages - Mailing list pgsql-hackers

From Nisha Moond
Subject Re: Improve the connection failure error messages
Date
Msg-id CABdArM41SRs_sX-G2xyc4RZVR5NDz4A9=Fh+2Hpj6iCYb=yhng@mail.gmail.com
Whole thread Raw
In response to Re: Improve the connection failure error messages  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Improve the connection failure error messages
Re: Improve the connection failure error messages
List pgsql-hackers
On Fri, Apr 26, 2024 at 1:10 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 22 Mar 2024, at 11:42, Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> > Here is the v4 patch with changes required in slotfuncs.c and slotsync.c files.
>
> -       errmsg("could not connect to the primary server: %s", err));
> +       errmsg("\"%s\" could not connect to the primary server: %s", app_name.data, err));
>
> Messages like this should perhaps have translator comments to indicate what the
> leading "%s" will contain?

Attached v5 patch with the translator comments as suggested.

--
Thanks,
Nisha

Attachment

pgsql-hackers by date:

Previous
From: Yao Wang
Date:
Subject: Re: 回复: An implementation of multi-key sort
Next
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15