Hello,
I tested the patch and it is working fine.
- I had clean system before but after running DockerBuild, I can see 3 different images of pgAdmin4, Is this expected?
Yes, this is expected and is the same for old docker image. Two unnamed images are temporary images from build process and can be safely removed, if you don't want cache for next builds.
- We can remove /tests/ folder from each folders, we can also remove /web/regression/ folder from the container, they are used to run tests.
We don't require them on production code.
Sounds reasonable. In fact, I believe I did that when making a prototype, but forgot to replicate in this patch. Will do.
- Can we make the ports configurable?
This is certainly doable. Please note, by the way, that pgadmin is now started on port 8080 or 8443 by default.
- Allow user to choose whether to run it as Single user mode(SERVER_MODE = False) or Multiuser mode(SERVER_MODE = True)