Re: IDLE in transaction introspection - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: IDLE in transaction introspection
Date
Msg-id CABUevEzj0GdmsvDtuBtKx_EBH6w9Zoy=rkJ=cqbJhgWwsvAADQ@mail.gmail.com
Whole thread Raw
In response to Re: IDLE in transaction introspection  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Thu, Jan 19, 2012 at 15:42, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Thu, Jan 19, 2012 at 10:31 PM, Magnus Hagander <magnus@hagander.net> wrote:
>> Applied with fairly extensive modifications. I moved things around,
>> switched to using enum instead of int+#define and a few things like
>> that. Also changed most of the markup in the docs - I may well have
>> broken some previously good language that, so if I did and someone
>> spots it, please mention it :-)
>
> The attached patch seems to need to be committed.

Thanks, applied.


> BTW, the following change in the patch is not required, but ISTM that
> it's better to change that way.
>
> -SELECT pg_stat_get_backend_pid(s.backendid) AS procpid,
> -       pg_stat_get_backend_activity(s.backendid) AS current_query
> +SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
> +       pg_stat_get_backend_activity(s.backendid) AS query

Agreed.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Online base backup from the hot-standby
Next
From: Simon Riggs
Date:
Subject: Re: Online base backup from the hot-standby