Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals
Date
Msg-id CABUevEzPtvyDKJo7bAbeePtTnzP2CfCOTZpbdU0g6UHVakxUtQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals  (James Sewell <james.sewell@lisasoft.com>)
Responses Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals
List pgsql-hackers

On Wed, Jul 3, 2013 at 3:04 AM, James Sewell <james.sewell@lisasoft.com> wrote:
Hey Peter,

You are correct, it is the same  as the referrals option in pam_ldap. It's also the -C (sometimes -R - it seems ldapsearch options are pretty non-standard) option in ldapsearch.

As far as I'm aware you can't pass this in an LDAP URL, primarily because this never gets sent to the LDAP server. The server always returns an LDIF with inline references, this just determines if you chase them client side or just list them as is.

I could be missing something here, but using:

 ldapreferrals={0|1}

Would require a three state type, as we need a way of not interfering with the library defaults? To 'enable' the new behavior here using a boolean you would need to set ldapreferrals=false - which with the normal way of dealing with config booleans would alter the default behavior if the option was not specified.

How do you feel about:

  ldapdisablereferrals=(0|1)


I agree with Peter that the negative thing is bad. l don't see the problem, really. If you don't specify it, you rely on library defaults. If you do specify it, we lock it to that setting. I don't see the need to specifically have a setting to rely on library defaults - just remove it from the line and you get that. 

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

pgsql-hackers by date:

Previous
From: Atri Sharma
Date:
Subject: Re: A better way than tweaking NTUP_PER_BUCKET
Next
From: KONDO Mitsumasa
Date:
Subject: Re: Improvement of checkpoint IO scheduler for stable transaction responses