On Thu, Nov 4, 2021 at 12:21 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> > As a general rule, please post the patches no the thread of the description, and if it's more than one patch, in
thesame email. Right now the only thing I see to review is this description, that's kind of hard.
>
> Sorry, I don't understand: should I send all patches by responding to the description email (instead of replying to
theprevious ones, as I did here), or all patches in the same email?
All in the same email is definitely best, like you did in this one -- thanks!
> > As for reviewing the general idea, I agree with that -- makes perfect sense to do that. I did note that Alvaro
spottedthat it also needs to look over all the rest of the text and find similar stuff -- like the image alt=""
attribute.There may be more of those?
>
> Yep, added handling of ORGANIZATION_MOTTO in the set of patches attached to this email.
Looking at 1 and 2, this just seems to me like a strange way to do it,
by declaring a new tag for it.
I think it would be cleaner with a Context Processor similar to what
we have in pgweb. Then this context processor could just return a dict
of ORGANIZATION_INFO from setitngs.py, wihch would have a key for name
and a key for motto perhaps?
As for 3 -- I don't think we want to remove the postgresql branding It
should be made optional though, perhaps by another parameter in said
dict in the settings that would just make it load from different URLs
and files?
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
