pg_xlogdump follow into the future - Mailing list pgsql-hackers

From Magnus Hagander
Subject pg_xlogdump follow into the future
Date
Msg-id CABUevEyvHFZTcVgztAU2zAwOoro=2a_92EAVjdKLAUsfz9H1Hw@mail.gmail.com
Whole thread Raw
Responses Re: pg_xlogdump follow into the future  (Simon Riggs <simon@2ndquadrant.com>)
Re: pg_xlogdump follow into the future  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Currently, if you run pg_xlogdump with -f, you have to specify an end position in an existing file, or if you don't it will only follow until the end of the current file.

That seems like an oversight - if you specify -f with no end position, it should follow "into the future" for any new files that appear. This allows us to track what's happening properly.

AFAICT the actual code tracks this just fine, but the option parsing prevents this from happening as it does not allow the end pointer to be unset. Attach patch fixes this and makes it follow "forever" if you specify -f without an end pointer.

I'd appreciate a review of that by someone who's done more work on the xlog stuff, but it seems trivial to me. Not sure I can argue it's a bugfix though, since the usecase simply did not work...
Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Oddity in handling of cached plans for FDW queries
Next
From: AMatveev@bitec.ru
Date:
Subject: Re: One process per session lack of sharing