Re: pgsql: Invent PGC_SU_BACKEND and mark log_connections/log_disconnection - Mailing list pgsql-committers

Invent PGC_SU_BACKEND and mark log_connections/log_disconnections that way.

This new GUC context option allows GUC parameters to have the combined
properties of PGC_BACKEND and PGC_SUSET, ie, they don't change after
session start and non-superusers can't change them.  This is a more
appropriate choice for log_connections and log_disconnections than their
previous context of PGC_BACKEND, because we don't want non-superusers
to be able to affect whether their sessions get logged.

Note: the behavior for log_connections is still a bit odd, in that when
a superuser attempts to set it from PGOPTIONS, the setting takes effect
but it's too late to enable or suppress connection startup logging.
It's debatable whether that's worth fixing, and in any case there is
a reasonable argument for PGC_SU_BACKEND to exist.

In passing, re-pgindent the files touched by this commit.

Fujii Masao, reviewed by Joe Conway and Amit Kapila

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fe550b2ac249af5fbd8e9e19290a4ba43c882f2d

Modified Files
--------------
doc/src/sgml/config.sgml          |   16 +++++----
src/backend/tcop/postgres.c       |    2 +-
src/backend/utils/init/postinit.c |    4 +--
src/backend/utils/misc/guc.c      |   66 +++++++++++++++++++++++--------------
src/include/utils/guc.h           |   20 ++++++-----
5 files changed, 65 insertions(+), 43 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers