Re: [PATCH] pgarchives: Bugfix: missing ids in pglister_sync - Mailing list pgsql-www

From Magnus Hagander
Subject Re: [PATCH] pgarchives: Bugfix: missing ids in pglister_sync
Date
Msg-id CABUevEyo3T2QY9sEFvthmNd2vYRzUnESWZ=i9GaotQsyhuEQww@mail.gmail.com
Whole thread Raw
In response to [PATCH] pgarchives: Bugfix: missing ids in pglister_sync  (Célestin Matte <celestin.matte@cmatte.me>)
Responses Re: [PATCH] pgarchives: Bugfix: missing ids in pglister_sync  (Célestin Matte <celestin.matte@cmatte.me>)
Re: [PATCH] pgarchives: Bugfix: missing ids in pglister_sync  (Célestin Matte <celestin.matte@cmatte.me>)
List pgsql-www
On Fri, Jan 28, 2022 at 6:52 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> groupid and listid are not explicitly set in pglister_sync's queries, which
> causes the script to fail as these fields are NOT NULL and postgresql default
> configuration does not auto-fill id fields.
>
> This patch sets them explicitly by reusing the ones obtained from pglister.

These fields are supposed to be serial fields, not pure integers, I
think. This feels like some very old legacy that hasn't been properly
fixed.

I think the attached patch is more correct (I've backpatched it into
the 0001 migration because making it a separate migration makes it
somewhat destructive -- it's easier to just change it manually on
existing installs if you have one)

--
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

Attachment

pgsql-www by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True
Next
From: Célestin Matte
Date:
Subject: Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True