Re: port _srv.o makefile rules don't observe dependency tracking - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: port _srv.o makefile rules don't observe dependency tracking
Date
Msg-id CABUevEyZ00MCRUSPNn9Yw7TRxos3sy62oDP3Eg++VOwm4SdADQ@mail.gmail.com
Whole thread Raw
In response to Re: port _srv.o makefile rules don't observe dependency tracking  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: port _srv.o makefile rules don't observe dependency tracking
List pgsql-hackers
On Tue, May 1, 2012 at 10:25 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>> Excerpts from Peter Eisentraut's message of mar may 01 15:30:25 -0400 2012:
>>> Instead, I thought this could easily be fixed by writing this:
>>>
>>> %_srv.o: %.c %.o
>>>      $(CC) $(CFLAGS) $(subst -DFRONTEND,, $(CPPFLAGS)) -c $< -o $@
>>>
>>> A bit hacky, but should get quite robust results.
>
>> So basically to build the _srv.o file you first need to build the .o?
>> Since both files need to be built anyway, I don't think this is a
>> problem.
>
> Are there, or might there be in the future, any "port" files that only
> exist in server flavor and not client-side flavor?  It doesn't seem
> terribly unlikely to me.  This is a cute hack but it assumes that
> everything in that directory can and should be built both ways.

Isn't that what backend/port/* is for?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: port _srv.o makefile rules don't observe dependency tracking
Next
From: Hannu Krosing
Date:
Subject: Re: JSON in 9.2 - Could we have just one to_json() function instead of two separate versions ?