On Tue, Nov 9, 2021 at 11:57 PM Nils Andre <nils@nilsand.re> wrote:
Hi,
On Mon, Nov 08, 2021 at 10:03:50AM +0100, Magnus Hagander wrote: > Yeah, I think the fact that it says bash is just a "knee-jerk default" and > not that it ever did either. So I have no problem changing that to sh. I'm > a bit curious though, as to in which scenario this actually causes a > problem?
This causes problems on [NixOS][1] which only has `/bin/sh` and `/usr/bin/env` in the location one would "expect" them.
Hmm. Interesting. Anyway, this part seems perfectly fine to fix.
> The second change I'm less sure about. There are many different things you > could change to break a script. This is one of them. You could change PATH, > or you could replace "find" or "xargs" with commands that don't work the > same way. CDPATH is not a variable that should, I believe, ever be exported > into non-interactive scripts in the first place.
I didn't realise I was exporting CDPATH, which is ~~probably~~ a mistake (and would have prevented previous painful and long headaches).
I'm pretty sure that one will break a lot of other things...
For what it's worth, I use a program I have written that makes use of CDPATH (and hence requires it to be exported (but I think I will reconsider the program's usage of CDPATH)).
I would recommend that :)
However I do understand this is an issue with my particular setup.
Attached, is the patch amended without the CDPATH change.
