Magnus Hagander <magnus@hagander.net> writes: > On Fri, Jul 3, 2020 at 6:12 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> The lack of documentation seems to be my fault, so I'm willing to pick >> this up unless somebody else wants it.
> If the comments I included in that patch are enough, I can just commit > those along with it. Otherwise, please do :)
Being once burned, I had something more like the attached in mind.
That's a bit more elaborate and yes, I agree, better.
BTW, looking at this, I'm kind of wondering about the other code path in SharedFileSetInit: