On Sun, Oct 23, 2016 at 5:48 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Magnus Hagander <magnus@hagander.net> writes: > The remaining windows buildfarm build issue looks like this: > src/bin/pg_basebackup/receivelog.c(135): error C2039: '_commit' : is > not a member of 'WalWriteMethod' > [C:\buildfarm\buildenv\HEAD\pgsql.build\pg_basebackup.vcxproj] > AFAICT this comes from using walmethod->fsync(), and we have a #define > changing fsync() to _commit (port/win32.h, line 70).
Yeah. > The easiest might just be to rename walmethod->fsync() to > walmethod->do_fsync(), so we don't have to mess with any other code.
How about calling the method just "sync()"? Seems a bit less artificial.
Sure, that should work too. Seems we're not defining that one to something else, so let's use that.
