Re: [bug fix] pg_ctl always uses the same event source - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [bug fix] pg_ctl always uses the same event source
Date
Msg-id CABUevExuHe6vChYEvf4D6Bae+rMkkgY1jcuYeCiUmZT=in-_5A@mail.gmail.com
Whole thread Raw
In response to Re: [bug fix] pg_ctl always uses the same event source  ("MauMau" <maumau307@gmail.com>)
Responses Re: [bug fix] pg_ctl always uses the same event source
List pgsql-hackers
On Sun, Dec 8, 2013 at 3:41 AM, MauMau <maumau307@gmail.com> wrote:
From: "MauMau" <maumau307@gmail.com>

I've removed a limitation regarding event log on Windows with the attached
patch.  I hesitate to admit this is a bug fix and want to regard this an
improvement, but maybe it's a bug fix from users' perspective.  Actually, I
received problem reports from some users.

I've done a small correction.  I removed redundant default value from the pg_ctl.c.

Not having looked at it in detail yet, but this seems to completely remove the default value. What happens if the error that needs to be logged is the one saying that it couldn't exec postgres to find out the value in the config file? AFAICT it's going to try to register an eventsource with whatever random garbage happens to be in the variable.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_stat_statements: calls under-estimation propagation
Next
From: Kohei KaiGai
Date:
Subject: Re: Custom Scan APIs (Re: Custom Plan node)