posix_fadvsise in base backups - Mailing list pgsql-hackers

From Magnus Hagander
Subject posix_fadvsise in base backups
Date
Msg-id CABUevExiw2RTx0dWKShKWmgL7gGRaGBpi+0=E+EkGXPZhAgNig@mail.gmail.com
Whole thread Raw
Responses Re: posix_fadvsise in base backups
List pgsql-hackers
Attached patch adds a simple call to posix_fadvise with
POSIX_FADV_DONTNEED on all the files being read when doing a base
backup, to help the kernel not to trash the filesystem cache.

Seems like a simple enough fix - in fact, I don't remember why I took
it out of the original patch :O

Any reason not to put this in? Is it even safe enough to put into 9.1
(probably not, but maybe?)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: unite recovery.conf and postgresql.conf
Next
From: Andres Freund
Date:
Subject: Re: posix_fadvsise in base backups