Re: Snapshot too old logging - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Snapshot too old logging
Date
Msg-id CABUevExMXqtOj+eEFpJyP5mbS9YNhBaWjC7qvKO4vJGDge-0VQ@mail.gmail.com
Whole thread Raw
In response to Re: Snapshot too old logging  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Snapshot too old logging
Re: Snapshot too old logging
Re: Snapshot too old logging
List pgsql-hackers
On Tue, Nov 15, 2016 at 5:29 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Kevin Grittner <kgrittn@gmail.com> writes:
> On Tue, Nov 15, 2016 at 3:38 AM, Magnus Hagander <magnus@hagander.net> wrote:
>> Is there a reason why we don't log which relation triggered the snapshot too
>> old error when it happens?

> I would probably not want to mess with the text of the error
> itself, in case any client-side software bases recovery on that
> rather than the SQLSTATE value;

Any such code is broken on its face because of localization.
Perhaps including the relname in the main message would make it
unduly long, but if not I'd vote for doing it that way.


Agreed.

Is there value in showing which snapshot as well? Something like:
DETAIL: snapshot <xyz> is too old to access relation <relation>

Putting both those into the main message will probably make it too long. 


--

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Patch: Implement failover on libpq connect level.
Next
From: Brad DeJong
Date:
Subject: Re: Snapshot too old logging