Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] pglister: auth_receive: Indicate when PGAUTH_KEY is invalid instead of crashing - Mailing list pgsql-www

From Magnus Hagander
Subject Re: [PATCH] pglister: auth_receive: Indicate when PGAUTH_KEY is invalid instead of crashing
Date
Msg-id CABUevExAh==A_kFJWcrmDgOBs5ur2bDTFt6WDqaYToqYQ3siow@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pglister: auth_receive: Indicate when PGAUTH_KEY is invalid instead of crashing  (Célestin Matte <celestin.matte@cmatte.me>)
List pgsql-www
Tree view 
On Thu, Jul 13, 2023 at 3:03 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> > It seems a patch like this was already merged into the upstream of
> > this, and got deployed into pgarchives & pglister when I synced those
> > up a couple of weeks ago. Sorry about the lateness of that one. Does
> > the current version of the code work for what you were looking for?
>
> This is the same as what my patch does, indeed

Thanks for confirming!


> > It might also be worth considering also checking explicitly for the
> > format of PGAUTH_KEY on startup. Something like the attached maybe?
> > (against pgweb which is the master of this file) What do you think?
>
> LGTM

I've applied this one to the upstream repo. Will merge it into the
other repos when it's time for the next round of updates there, I
don't think it's high prio enough to do a "all around run".

//Magnus

pgsql-www by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [PATCHES] pglister & pgarchives: add deployment tests for gitlab-ci
Next
From: Erik Wienhold
Date:
Subject: Broken links in mailinglist archive due to percent-encoding