Postgres Pro
Downloads
Home   >   mailing lists

pg_control read error message - Mailing list pgsql-hackers

From Magnus Hagander
Subject pg_control read error message
Date
Msg-id CABUevEx8ZRV5Ut_FvP2etXiQppx3xVzm7oOaV3AcdHxX81Yt8Q@mail.gmail.com
Whole thread Raw
Responses Re: pg_control read error message  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Tree view
If pg_control is for some reason empty, we give an error messagfe like:

2018-05-18 13:24:03.342 CEST [19697] PANIC:  could not read from control file: Success

Which is, uh, wrong -- it's definitely not successful.

Obviously this is a state where the user is fairly screwed anyway, but we should give a better message.

Attached is a patch that does this. Reasonable?

--
Attachment

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: inconsistency and inefficiency in setup_conversion()
Next
From: John Naylor
Date:
Subject: Re: master fails to build on Windows