On Fri, Dec 16, 2016 at 11:36 PM, Magnus Hagander <magnus@hagander.net> wrote: > On Thu, Dec 15, 2016 at 12:37 AM, Vladimir Rusinov <vrusinov@google.com> > wrote: >> >> Usability review >> >> ============ >> >> >> Patch sounds like a good idea and does what it supposed to do. /me in DBA >> hat will be happy to have it. >> >> However, it makes '-x' parameter a bit confusing/surprising: specifying it >> will be equivalent to '-X fetch' which is surprising regression from the new >> default. > > > This seems like a good idea, really. > > Given that we already break a number of other things around backups and > replication in this release, it seems like a good time. > > I definitely think removing it is what we should do -- let's not redefine it > to mean streaming, let's just get rid of -x altogether, and have people use > -X streaming|fetch|none. > > What do others feel about this?
+1 to drop -x option. That's less confusing.
Attached is an updated patch that does this. As a bonus it simplifies the code a bit. I also fixed an error message that I missed updating in the previous patch.
