[HACKERS] Vacuum full stats reporting - Mailing list pgsql-hackers

From Magnus Hagander
Subject [HACKERS] Vacuum full stats reporting
Date
Msg-id CABUevEwkMTi3JwQ1peu2RQjt-rK4EJLbaXE1=mxiy1DUjWiRLw@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Vacuum full stats reporting  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Right now, VACUUM FULL are not reported in pgstat. That seems bad:ish. I can see two reasonable ways to proceed:

1. Start reporting VACUUM FULL as regular vacuums, so they count up vacuum_count and last_vacuum in pg_stat_*_tables.

2. Create a new set of counters for CLUSTER and VACUUM FULL (which are arguably the same in this regard, in how they behave wrt the system), and add counters cluster_count and last_cluster in pg_stat_*_tables.

Option 2 clearly adds more information and I can see quite a few cases where this would be useful. But what do people think of the potential overhead there? Worth it?

Due to this, it also does not (AFAICT) reset the counters for things like dead tuples. This part seems like a pure bug. Perhaps we should at least do something like (1) as a backpatch, even if we decide to do (2) in future versions (11+ i guess)?

--

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [HACKERS] SCRAM authentication, take three
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.