pg_upgrade analyze script - Mailing list pgsql-hackers

From Magnus Hagander
Subject pg_upgrade analyze script
Date
Msg-id CABUevEwg5LDFzthhxzSj7sZGMiVsZe0VVNbzzwTQOHJ=rN7+5A@mail.gmail.com
Whole thread Raw
Responses Re: pg_upgrade analyze script  (Bruce Momjian <bruce@momjian.us>)
Re: pg_upgrade analyze script  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh) that just calls vacuumdb to run the analyze in stages. This script made a lot of sense back when it actually implemented the stages, but these days since it's just calling a single command, I think it's just unnecessary complication.

I suggest we drop it and just replace it with instructions to call vacuumdb directly.

Attached patch does this. It also removes the support in the instructions that talk about pre-8.4 databases, which I believe is dead code per https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493MJt-x6sppbUxA@mail.gmail.com.

--
Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pg_upgrade dead code for pre-8.4 versions
Next
From: Bharath Rupireddy
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)