On Tue, Oct 6, 2020 at 9:05 PM Bruce Momjian <bruce@momjian.us> wrote:
On Tue, Oct 6, 2020 at 11:43:01AM +0200, Magnus Hagander wrote: > For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh) that > just calls vacuumdb to run the analyze in stages. This script made a lot of > sense back when it actually implemented the stages, but these days since it's > just calling a single command, I think it's just unnecessary complication. > > I suggest we drop it and just replace it with instructions to call vacuumdb > directly.
Uh, that script has instructions on what is running. Do we want to show that at the end of running pg_upgrade or do people understand "stages" by now?
I think that's information that belongs in the documentation, for those that case. I'm willing to bet that the large majority of the people who run the script never read that, and certainly don't cancel it. Those that need it to their upgrade planning long before they get to that stage.
