Prevent pg_basebackup -Fp -D -? - Mailing list pgsql-hackers

From Magnus Hagander
Subject Prevent pg_basebackup -Fp -D -?
Date
Msg-id CABUevEw3wdhGqPq=oo9yzr9EOsFL_zzXSn_gk0kJbJx-4UVvGA@mail.gmail.com
Whole thread Raw
Responses Re: Prevent pg_basebackup -Fp -D -?  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Right now, if you use

pg_basebackup -Ft -D -

you get a tarfile, written to stdout, for redirection.

However, if you use:

pg_basebackup -Fp -D -

you get a plaintext (unpackaged) backup, in a directory called "-".

I can't think of a single usecase where this is a good idea. Therefor,
I would suggest we simply throw an error in this case, instead of
creating the directory. Only for the specific case of specifying
exactly "-" as a directory.

Comments?

Also, if we do that, is this something we should consider
backpatchable? It's not strictly speaking a bugfix, but I'd say it
fixes some seriously annoying behavior.


-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/



pgsql-hackers by date:

Previous
From: Oskari Saarenmaa
Date:
Subject: Re: [PATCH] pg_upgrade: support for btrfs copy-on-write clones
Next
From: Ants Aasma
Date:
Subject: Re: [PERFORM] Cpu usage 100% on slave. s_lock problem.