Postgres Pro
Downloads
Home   >   mailing lists

[PATCH] Minor cleanups of BRIN code - Mailing list pgsql-hackers

From Marti Raudsepp
Subject [PATCH] Minor cleanups of BRIN code
Date
Msg-id CABRT9RDo+W5PtGuPBrQLnC+pV1HCBYMNymJ=0y3NGcZSrwFu1w@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Tree view 
Hi list,

I was messing around a bit with BRIN code and found some cleanups to be made:
1. Remove dead code in brin_form_tuple
2. Add missing Datum conversion macros
3. Use AttrNumber type in places using 1-based attribute numbers

Though it's not hard to find cases all over source code similar to (2)
and (3), are these kinds of cleanups considered useful?

Regards,
Marti Raudsepp
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_partition_tree crashes for a non-defined relation
Next
From: Alexander Korotkov
Date:
Subject: Re: Connections hang indefinitely while taking a gin index's LWLockbuffer_content lock