[PATCH] Cleanup: unify checks for catalog modification - Mailing list pgsql-hackers

From Marti Raudsepp
Subject [PATCH] Cleanup: unify checks for catalog modification
Date
Msg-id CABRT9RB3AiULxzeTUZ-c-wpYdvfMGbxG4fPne38vtRNdm86Svw@mail.gmail.com
Whole thread Raw
Responses Re: [PATCH] Cleanup: unify checks for catalog modification
List pgsql-hackers
Hi list,

I happened to notice that there are no less than 14 places in the code
that check whether a relation is a system catalog and throwing the
error "permission denied: "foo" is a system catalog"

The attached patch factors all of those into a single
ForbidSystemTableMods() function. Is this considered an improvement?
Should I add it to CommitFest?

Regards,
Marti

Attachment

pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: narwhal and PGDLLIMPORT
Next
From: Andrew Dunstan
Date:
Subject: Re: narwhal and PGDLLIMPORT