Re: Patch review for logging hooks (CF 2012-01) - Mailing list pgsql-hackers

From Marti Raudsepp
Subject Re: Patch review for logging hooks (CF 2012-01)
Date
Msg-id CABRT9RAUMWifGz7CCDokZSMd+8RwbLjguyOekGWTOrG-We6Tgg@mail.gmail.com
Whole thread Raw
In response to Re: Patch review for logging hooks (CF 2012-01)  (Martin Pihlak <martin.pihlak@gmail.com>)
Responses Re: Patch review for logging hooks (CF 2012-01)  (Martin Pihlak <martin.pihlak@gmail.com>)
List pgsql-hackers
Hi!

On Tue, Jan 17, 2012 at 23:07, Martin Pihlak <martin.pihlak@gmail.com> wrote:
>> I think the hook warrants a comment that, whether the messages will be
>> seen, depends on the log_min_messages setting.
>
> Comment added.

Nice :)

It seems you missed a comment, that the current implementation is also
affected by client_min_messages. I think that being affected by
client-specific settings is surprising. I would put the
if(emit_log_hook) inside the existing if(edata->output_to_server)
condition. Unless you have some reason to do it this way?

Regards,
Marti


pgsql-hackers by date:

Previous
From: Martin Pihlak
Date:
Subject: Re: Patch review for logging hooks (CF 2012-01)
Next
From: Daniel Farina
Date:
Subject: Re: Should we add crc32 in libpgport?