Re: pg_ugprade test failure on data set with column with defaultvalue with type bit/varbit - Mailing list pgsql-hackers

From Paul Guo
Subject Re: pg_ugprade test failure on data set with column with defaultvalue with type bit/varbit
Date
Msg-id CABQrizfURD9FR-yZ1bTCAZaK=MehOGdYhi7CmXsDdDU13-oLPw@mail.gmail.com
Whole thread Raw
In response to Re: pg_ugprade test failure on data set with column with defaultvalue with type bit/varbit  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: pg_ugprade test failure on data set with column with defaultvalue with type bit/varbit
Re: pg_ugprade test failure on data set with column with default value with type bit/varbit
List pgsql-hackers
Thanks. I updated the patch as attached.

Double-checked those tests passed.

2018-07-30 9:38 GMT+08:00 Thomas Munro <thomas.munro@enterprisedb.com>:
On Thu, May 17, 2018 at 8:20 PM, Paul Guo <paulguo@gmail.com> wrote:
> Thanks. I tentatively submitted a patch (See the attachment).

Hi Paul,

It looks like you missed a couple of changes in the contrib/btree_gist
bit and varbit tests, so make check-world fails:

- Index Cond: ((a >= B'1000000'::"bit") AND (a <= B'1000001'::"bit"))
+ Index Cond: ((a >= '1000000'::"bit") AND (a <= '1000001'::"bit"))

--
Thomas Munro
http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Should contrib modules install .h files?
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Documentaion fix.