Re: Add new wait event to XactLockTableWait - Mailing list pgsql-hackers

Just CC.

On Mon, Jun 9, 2025 at 10:57 AM Xuneng Zhou <xunengzhou@gmail.com> wrote:
>
> Hi Michael,
>
> Thanks for reviewing.
>
> On Mon, Jun 9, 2025 at 6:41 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> > +     pgstat_report_wait_start(WAIT_EVENT_XACT_DONE);
> > [...]
> > +     pgstat_report_wait_start(WAIT_EVENT_XACT_DONE);
> >
> > Wouldn't it be better to use two wait events named differently to be
> > able to make the difference between the two code paths?
> > --
>
> Both `XactLockTableWait()` and its conditional sibling ultimately
> block on the same thing: “other transaction must commit or abort
> before I can proceed.”  I think that using one identifier might keep
> the catalog simple.
>
> Best regards,
> Xuneng