[Report Bug With Patch] Rel Cache Bug - Mailing list pgsql-bugs

From Jaimin Pan
Subject [Report Bug With Patch] Rel Cache Bug
Date
Msg-id CABP8UDQH3T=AMNvPd1e743HUt52TYQpciH-P2WEU7pY9nJkDwQ@mail.gmail.com
Whole thread Raw
Responses Re: [Report Bug With Patch] Rel Cache Bug  (Andres Freund <andres@2ndquadrant.com>)
Re: [Report Bug With Patch] Rel Cache Bug  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Hi,

I think there is a bug in rel cache rebuild of release 9.4.1. 
it also exists on some other release.

the issue was introduced by 491dd4a97daa6b4de9ee8401ada10ad5da76af46

-- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -2166,9 +2166,9 @@ RelationClearRelation(Relation relation, bool rebuild)
                /* ... but actually, we don't have to update newrel->rd_rel */
                memcpy(relation->rd_rel, newrel->rd_rel, CLASS_TUPLE_SIZE);
                /* preserve old tupledesc and rules if no logical change */
-               if (keep_tupdesc)
+               if (!keep_tupdesc)
                        SWAPFIELD(TupleDesc, rd_att);
-               if (keep_rules)
+               if (!keep_rules)
                {
                        SWAPFIELD(RuleLock *, rd_rules);
                        SWAPFIELD(MemoryContext, rd_rulescxt);
Attachment

pgsql-bugs by date:

Previous
From: Pedro Gimeno
Date:
Subject: Re: BUG #12885: The result of casting a double to an integer depends on the database version
Next
From: smarvin@pobox.com
Date:
Subject: BUG #12897: SQLDescribeColumn() and bit columns