Postgres Pro
Downloads
Home   >   mailing lists

Re: Bugs in TOAST handling, OID assignment and redo recovery - Mailing list pgsql-hackers

From Pavan Deolasee
Subject Re: Bugs in TOAST handling, OID assignment and redo recovery
Date
Msg-id CABOikdPUZibDocaz0Ph9mGfEFhs+rUbn97uayL3rYDACzN42Ww@mail.gmail.com
Whole thread Raw
In response to Re: Bugs in TOAST handling, OID assignment and redo recovery  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bugs in TOAST handling, OID assignment and redo recovery
List pgsql-hackers
Tree view


On Thu, Apr 12, 2018 at 1:58 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
So while looking at this, it suddenly occurred to me that probing with
SnapshotDirty isn't that safe for regular (non-TOAST) Oid assignment
either.  

Yeah it occurred to me as well, but when I looked at the code, I couldn't find a case that is broken. I even tried a few test cases with DDLs etc. But I think what you did is fine and more bullet proof. So +1 to that.

Thanks,
Pavan

--
 Pavan Deolasee                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Creation of wiki page for open items of v11
Next
From: Ashutosh Bapat
Date:
Subject: Re: Creation of wiki page for open items of v11