Re: Potential ABI breakage in upcoming minor releases - Mailing list pgsql-hackers

From Pavan Deolasee
Subject Re: Potential ABI breakage in upcoming minor releases
Date
Msg-id CABOikdOQK4=xCLRE5a41=brZi-RJw=scnSq4JN3RjqL9x31k6A@mail.gmail.com
Whole thread Raw
In response to Re: Potential ABI breakage in upcoming minor releases  (Pavan Deolasee <pavan.deolasee@gmail.com>)
Responses Re: Potential ABI breakage in upcoming minor releases
List pgsql-hackers


On Fri, Nov 15, 2024 at 11:39 PM Pavan Deolasee <pavan.deolasee@gmail.com> wrote:

Looking more carefully at the usage of `ResultRelInfo` in the PGD code, I think we might also be impacted by it. At one place, we loop through the `es_result_relations` array and a size mismatch there will cause problems. Interestingly, in v14 and above, we read from `es_opened_result_relations`, which is a List, so it should be safe. I will try some tests on v13 to see if they result in crashes. But it seems quite likely by reading the code.


Ah, the addition of a member to `ResultRelInfo` did not happen in v12 and v13, even though the commit was backpatched all the way to v12. Maybe we (PGD) got twice lucky :-) There could be other extensions which might be looping through `es_result_relations` though and get impacted.

Thanks,
Pavan 

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Potential ABI breakage in upcoming minor releases
Next
From: Noah Misch
Date:
Subject: Re: Potential ABI breakage in upcoming minor releases