PATCH: Fix wrong size argument to pg_strncasecmp - Mailing list pgsql-hackers

From Dominik Czarnota
Subject PATCH: Fix wrong size argument to pg_strncasecmp
Date
Msg-id CABEVAa1dU0mDCAfaT8WF2adVXTDsLVJy_izotg6ze_hh-cn8qQ@mail.gmail.com
Whole thread Raw
Responses Re: PATCH: Fix wrong size argument to pg_strncasecmp
List pgsql-hackers
Hello,

Please find a one-liner patch in the attachment.

This patch fixes a size parameter of `pg_strncasecmp` which compared a "string" literal with a variable by passing a size of 5 while the "string" literal has 6 bytes.

This issue can be observed with the following query (where 'X' is any character other than 'g' and null byte):

    select json_to_tsvector('"abc"'::json, '"strinX"')

Before this patch this query returns the `'abc':1` result instead of failing with the following error:

    wrong flag in flag array: "strinX"

By the way, the `strncasecmp` usages around the fixed line could use `strcasecmp` which doesn't accept the `size_t n` argument.

---
Regards,
Disconnect3d
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Proposal: Add more compile-time asserts to exposeinconsistencies.
Next
From: Thomas Munro
Date:
Subject: Re: Tweaking DSM and DSA limits