Re: Bug report: OIDs, roles and Windows (signedness issue?) - Mailing list pgadmin-hackers

From Ian Lawrence Barwick
Subject Re: Bug report: OIDs, roles and Windows (signedness issue?)
Date
Msg-id CAB8KJ=gG-yvKN_YCDBUvhdBrqkiVGLi55hdPtys89szKg4u2ag@mail.gmail.com
Whole thread Raw
In response to Re: Bug report: OIDs, roles and Windows (signedness issue?)  (Ian Lawrence Barwick <barwick@gmail.com>)
Responses Re: Bug report: OIDs, roles and Windows (signedness issue?)  (Ian Lawrence Barwick <barwick@gmail.com>)
List pgadmin-hackers
2013/11/22 Ian Lawrence Barwick <barwick@gmail.com>:

>>
>> BTW other objects (tables, schemas etc.) with OIDs greater than 256^4/2 - 1
>> don't seem to be affected by this.
>
> It's been a while since I've looked at the pgAdmin source, but some wild
> grepping shows that in:
>
>   pgadmin/schema/pgRole.cpp
>
> the role OID is set with:
>
>  role->iSetOid(roles->GetLong(wxT("oid")));
>
> whereas almost everywhere else it's set with GetOid(), e.g.
>
>  table->iSetOid(tables->GetOid(wxT("oid")));
>
> which may or may not have something to do with the issue.

If that is the problem, then here's a patch. Untested as I don't have a Windows
build environment available, though I might be able to cobble one together
next week.

Regards

Ian  Barwick

Attachment

pgadmin-hackers by date:

Previous
From: Ian Lawrence Barwick
Date:
Subject: Re: Bug report: OIDs, roles and Windows (signedness issue?)
Next
From: Akshay Joshi
Date:
Subject: Fixed database statistics report issue