Postgres Pro
Downloads
Home   >   mailing lists

Re: PostgresNode::_update_pid using undefined variables in tap tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: PostgresNode::_update_pid using undefined variables in tap tests
Date
Msg-id CAB7nPqTth_K_9=5rv-n1Mv2SRh7pzoKy28fq8_BPCmmNz28K6A@mail.gmail.com
Whole thread Raw
In response to Re: PostgresNode::_update_pid using undefined variables in tap tests  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Wed, Dec 9, 2015 at 8:57 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Michael Paquier wrote:
>
>> This code should have checked for the return result of open instead of
>> looking at $pidfile. This has been noticed by Noah as well afterwards
>> and already addressed as 9821492.
>
> Oops, sorry I didn't credit you in the commit message.

That's fine. Don't worry.
-- 
Michael

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Fwd: Another little thing about psql wrapped expanded output
Next
From: Michael Paquier
Date:
Subject: Re: proposal: multiple psql option -c