On Thu, Jan 19, 2017 at 9:28 PM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
> On Thu, Jan 19, 2017 at 1:26 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> On Thu, Jan 19, 2017 at 4:25 PM, Haribabu Kommi
>> <kommi.haribabu@gmail.com> wrote:
>>> Added the cleanup mechanism. But the tokenize_file() function call
>>> present in many places, But in one flow still it is possible to have
>>> file descriptor leak because of pg_hba_rules view. Because of this
>>> reason, added the cleanup everywhere.
>>
>> Oops, sorry. Actually you don't need that. AllocateFile() registers
>> the fd opened with the sub-transactions it is involved with... So if
>> there is an ERROR nothing leaks.
>
> I agree. If we need any fix, it should be a separate patch.
It happens that no fix is needed here. That was some useless fuss. Sorry.
--
Michael
