Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] pg_hba_file_settings view patch - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] pg_hba_file_settings view patch
Date
Msg-id CAB7nPqTnPMSfZaFs+F_caRsga7NJM6iV8k877bTEJTD-cGXMkw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] pg_hba_file_settings view patch  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: [HACKERS] pg_hba_file_settings view patch  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
Tree view 
On Thu, Jan 19, 2017 at 4:25 PM, Haribabu Kommi
<kommi.haribabu@gmail.com> wrote:
> Added the cleanup mechanism. But the tokenize_file() function call
> present in many places, But in one flow still it is possible to have
> file descriptor leak because of pg_hba_rules view. Because of this
> reason, added the cleanup everywhere.

Oops, sorry. Actually you don't need that. AllocateFile() registers
the fd opened with the sub-transactions it is involved with... So if
there is an ERROR nothing leaks.
-- 
Michael

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] patch: function xmltable
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Patch to implement pg_current_logfile() function