Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Date
Msg-id CAB7nPqTnAyTwrnXfyJdmovu0B991KK3tymgW5NNtPWyU=fhNzQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY  (Kevin Grittner <kgrittn@ymail.com>)
List pgsql-committers
Tree view 
On Fri, Jul 17, 2015 at 11:16 PM, Kevin Grittner <kgrittn@ymail.com> wrote:
> Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote:
>
>> This fixes bug #13126, reported by Kirill Simonov.
>
> It looks like you missed something with the addition of
> AT_ReAddComment:
>
> test_ddl_deparse.c:80:11: warning: enumeration value 'AT_ReAddComment' not handled in switch [-Wswitch]
>                 switch (subcmd->subtype)
>                         ^

Oops. If someone could pick up the attached (backpatch to 9.5 needed)...
--
Michael
Attachment

pgsql-committers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Next
From: Tom Lane
Date:
Subject: pgsql: Fix entirely broken permissions test in new alter_operator regre