[HACKERS] Improving overflow checks when adding tuple to PGresult Re: [GENERAL]Retrieving query results - Mailing list pgsql-hackers

From Michael Paquier
Subject [HACKERS] Improving overflow checks when adding tuple to PGresult Re: [GENERAL]Retrieving query results
Date
Msg-id CAB7nPqTnA3No2_B6x-QXPLHga1HatPqmXd03Xub+rPpshpmyMA@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Improving overflow checks when adding tuple to PGresult Re: [GENERAL] Retrieving query results  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Aug 28, 2017 at 3:05 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Attached are two patches:
> 1) 0001 refactors the code around pqAddTuple to be able to handle
> error messages and assign them in PQsetvalue particularly.
> 2) 0002 adds sanity checks in pqAddTuple for overflows, maximizing the
> size of what is allocated to INT_MAX but now more.
>
> pqRowProcessor() still has errmsgp, but it is never used on HEAD. At
> least with this set of patches it comes to be useful. We could rework
> check_field_number() to use as well an error message string, but I
> have left that out to keep things simple. Not sure if any complication
> is worth compared to just copying the error message in case of an
> unmatching column number.

As this change requires I think an extra lookup, I am moving the
discussion to -hackers with a proper subject and the set of patches
attached (and the test program). This patch is registered in the next
commit fest.
-- 
Michael

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Protect syscache from bloating with negative cache entries