Postgres Pro
Downloads
Home   >   mailing lists

Nitpicking: unnecessary NULL-pointer check in pg_upgrade's controldata.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Nitpicking: unnecessary NULL-pointer check in pg_upgrade's controldata.c
Date
Msg-id CAB7nPqTmLvKZKrtNQ0+jc7SAnKDe0w_udkt8JCO6z_5Lgq5H_A@mail.gmail.com
Whole thread Raw
Responses Re: Nitpicking: unnecessary NULL-pointer check in pg_upgrade's controldata.c  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
Hi,

Coverity is nitpickingly pointing out the following thing:
--- a/src/bin/pg_upgrade/controldata.c
+++ b/src/bin/pg_upgrade/controldata.c
@@ -402,8 +402,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)               }       }

-       if (output)
-               pclose(output);
+       pclose(output);
The thing is that output can never be NULL, pg_upgrade leaving with
pg_fatal before coming to this code path. Hence this NULL check could
be simply removed.
Regards,
-- 
Michael

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Next
From: Andres Freund
Date:
Subject: Re: Nitpicking: unnecessary NULL-pointer check in pg_upgrade's controldata.c