Re: pgsql: psql: fix \connect with URIs and conninfo strings - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: psql: fix \connect with URIs and conninfo strings
Date
Msg-id CAB7nPqTkUb7TMt5qKTKk1Pw=9g7thLpVRaBtqNmn=3_JQ53bYA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: psql: fix \connect with URIs and conninfo strings  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: pgsql: psql: fix \connect with URIs and conninfo strings  (Michael Paquier <michael.paquier@gmail.com>)
Re: pgsql: psql: fix \connect with URIs and conninfo strings  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers


On Thu, Apr 2, 2015 at 10:29 AM, Michael Paquier <michael.paquier@gmail.com> wrote:



On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
psql: fix \connect with URIs and conninfo strings

psql was already accepting conninfo strings as the first parameter in
\connect, but the way it worked wasn't sane; some of the other
parameters would get the previous connection's values, causing it to
connect to a completely unexpected server or, more likely, not finding
any server at all because of completely wrong combinations of
parameters.

My box complains as well.

I haven't looked at that in details, but it looks that there are linking problems with -lpgcommon, as it is the first time that libpq has a dependency with it.

I am seeing as well that this is at least missing at the top of connstring.c:
#ifndef FRONTEND
#error "This file is not expected to be compiled for backend code"
#endif
And that src/tools/msvc has not been updated to have connstring.c show up in the list of frontend-only objects for libpgcommon.

On other Linux machines, tests for dblink are failing:
+ ERROR: could not load library "/usr/src/pgfarm/build/HEAD/inst/lib/postgresql/dblink.so": /usr/src/pgfarm/build/HEAD/inst/lib/libpq.so.5: undefined symbol: libpq_connstring_is_recognized
--
Michael

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: psql: fix \connect with URIs and conninfo strings
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: psql: fix \connect with URIs and conninfo strings