Re: Multiple false-positive warnings from Valgrind - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Multiple false-positive warnings from Valgrind
Date
Msg-id CAB7nPqTgzjmLyAHZe1HGKXti0hs9E7w-0SFFf0d9v9w0PMW72A@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Multiple false-positive warnings from Valgrind  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
List pgsql-hackers
On Sat, Apr 1, 2017 at 2:51 PM, Noah Misch <noah@leadboat.com> wrote:
> Does this remove the noise under --with-openssl?
>
> --- a/src/port/pg_strong_random.c
> +++ b/src/port/pg_strong_random.c
> @@ -104,7 +104,10 @@ pg_strong_random(void *buf, size_t len)
>          */
>  #if defined(USE_OPENSSL_RANDOM)
>         if (RAND_bytes(buf, len) == 1)
> +       {
> +               VALGRIND_MAKE_MEM_DEFINED(buf, len);
>                 return true;
> +       }
>         return false;
>
>         /*

Actually, no. I'll dig more into the options of valgrind to see if I
am missing something here..
-- 
Michael



pgsql-hackers by date:

Previous
From: anant khandelwal
Date:
Subject: GSoC 2017 Proposal for "Explicitly support predicate locks in indexaccess methods besides btree"
Next
From: Robert Haas
Date:
Subject: Re: [COMMITTERS] pgsql: Avoid GatherMerge crash when there are no workers.