On Tue, Sep 8, 2015 at 9:32 AM, Alvaro Herrera wrote:
> Michael Paquier wrote:
> I made a couple extra cleanups to the patch, namely: do not call
> CreateTemplateTupleDesc() just to discard the resulting tupdesc with a
> subsequent get_call_result_type(); and do not write a \0 to the
> BIO_s_mem, and instead use BIO_get_mem_data's return value as length
> when converting str to text *.
Thanks!
> FWIW I now think I made a mistake with the error checks that I
> backpatched, because the wording of the error messages I used "failed to
> foo" is frowned upon by our message style guidelines. Should be "could
> not do foo" instead.
Well... Feel free to use that if it makes you gain two minutes.
--
Michael
